On Mon, 13 Mar 2023 21:04:22 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Interpreter optimization and comments
>
> src/hotspot/cpu/x86/interp_masm_x86.cpp line 2075:
>
>> 2073: movptr(cache, Address(rbp, frame::interpreter_frame_cache_offset *
>> wordSize));
>> 2074: movptr(cache, Address(cache,
>> in_bytes(ConstantPoolCache::invokedynamic_entries_offset())));
>> 2075: if (is_power_of_2(sizeof(ResolvedIndyEntry))) {
>
> This was a good suggestion but I wonder if we should assert ResolvedIndyEntry
> is a power of 2 so we know if we change the size and make it go the slower
> path? Or is 32 bit not a power of two and we need this?
Currently the structure is a power of two on 64 bits but this is not the case
on 32 bit systems.
-------------
PR: https://git.openjdk.org/jdk/pull/12778
