On Fri, 19 May 2023 17:11:36 GMT, Alan Bateman <[email protected]> wrote:
>> This is the implementation for JEP 451. There are two parts to this:
>>
>> 1. A multi-line warning is printed when a JVM TI or Java agent is loaded
>> into a running VM. For JVM TI, the message is printed to stderr from
>> JvmtiAgent::load. For Java agents, it is printed to System.err (as that may
>> be redirected) in the JPLIS (j.l.instrumentation) implementation. This part
>> includes an update to the JVM TI spec and API docs to require the warning.
>>
>> 2. If running with -Djdk.instrument.traceUsage or
>> -Djdk.instrument.traceUsage=true, the calls to the Instrumentation API print
>> a trace message and stack trace.
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains 10 additional
> commits since the last revision:
>
> - Merge
> - Refresh package description
> - Merge
> - Tweak docs
> - Merge
> - Draft docs changes
> - Merge
> - Rename/cleanup
> - Merge
> - Initial commit
The fix looks good. Posted one nit though.
Thanks,
Serguei
test/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.java line 197:
> 195: // launch application with the given VM options, waiting for
> it to terminate
> 196: Stream<String> s1 = Stream.of(vmopts);
> 197: Stream<String> s2 = Stream.of("Application",
> ""+listener.getLocalPort());
Nit: Spaces are missed around '+' sign at lines: 121, 180 and 197.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13899#pullrequestreview-1437842664
PR Review Comment: https://git.openjdk.org/jdk/pull/13899#discussion_r1201276466
