On Thu, 22 Jun 2023 09:53:29 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Currently, a number of tests fail on macOS because they miss the core file
>> (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not
>> work ("checking if debug mode codesign is possible... no) .
>> So adding the needed entitlement to generate cores is not done in the build.
>> This is currently not checked later in the tests.
>> But without the entitlement, a core is not generated.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Some adjustments
Looks a bit better. But I think instead of adding a Utils.javaPath() method,
you can do all this path handling in Platform.launchCodesignOnJavaBinary().
Then even more code would be shared.
test/lib/jdk/test/lib/Platform.java line 263:
> 261: }
> 262:
> 263: private static codesignProcess launchCodesignOnJavaBinary(String
> javaFileName) {
That can't work... should be `private static Process` 😉
-------------
Changes requested by clanger (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14562#pullrequestreview-1492927024
PR Review Comment: https://git.openjdk.org/jdk/pull/14562#discussion_r1238354879
