On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang <yy...@openjdk.org> wrote: >> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap >> with 96threads and fixes a memory leak of compressor >> >> You might argue why this is Linux-only optimization, because sendfile >> requires at least socket fd in other platforms([aix >> sendfile](https://www.ibm.com/docs/en/aix/7.1?topic=s-send-file-subroutine) >> [maxos >> sendfile](https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/sendfile.2.html) >> [win32 >> TransmitFile](https://learn.microsoft.com/en-us/windows/win32/api/mswsock/nf-mswsock-transmitfile)), >> while [only Linux](https://man7.org/linux/man-pages/man2/sendfile.2.html) >> supports both two file descriptors. > > Yi Yang has updated the pull request incrementally with one additional commit > since the last revision: > > one merge_file for all
I had not noticed this PR sorry. I do not like the fact we have Linux-only functionality being added with no intent to supply similar functionality on other platforms. I also do not like the fact we had to ifdef the Linux code into the shared code. It would have been metter to place the code in os::Linux and then have a single LINUX_ONLY() to make that call. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15245#issuecomment-1728623448
