On Thu, 21 Sep 2023 01:18:19 GMT, David Holmes <dhol...@openjdk.org> wrote:

> I had not noticed this PR sorry. I do not like the fact we have Linux-only 
> functionality being added with no intent to supply similar functionality on 
> other platforms. I also do not like the fact we had to ifdef the Linux code 
> into the shared code. It would have been metter to place the code in 
> os::Linux and then have a single LINUX_ONLY() to make that call.

Okay, I'll prepare a follow-up PR to do this once 
https://github.com/openjdk/jdk/pull/15843 merged.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15245#issuecomment-1728662913

Reply via email to