On Fri, 22 Sep 2023 02:40:39 GMT, David Holmes <[email protected]> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> other size_t flags than the ArrayAllocatorMallocLimit are used in tests.
>
> test/hotspot/jtreg/serviceability/attach/AttachSetGetFlag.java line 64:
>
>> 62: testGetFlag("ArrayAllocatorMallocLimit", "128");
>> 63: // testSetFlag("ArrayAllocatorMallocLimit", "64", "128");
>> 64:
>
> You need to replace this with another non-manageable size_t flag so that code
> coverage is maintained.
Fixed.
> test/lib-test/jdk/test/whitebox/vm_flags/SizeTTest.java line 1:
>
>> 1: /*
>
> This test also should not be removed but changed to use a different size_t
> flag so that the WB functionality continues to be tested for a flag of this
> type.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1335611692
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1335611842
