On Tue, 26 Sep 2023 02:07:41 GMT, David Holmes <[email protected]> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> other size_t flags than the ArrayAllocatorMallocLimit are used in tests.
>
> test/lib-test/jdk/test/whitebox/vm_flags/SizeTTest.java line 38:
>
>> 36:
>> 37: public class SizeTTest {
>> 38: private static final String FLAG_NAME =
>> "StringDeduplicationCleanupDeadMinimum";
>
> Again a non-experimental flag, like MetaspaceSize, might be better here.
`MetaspaceSize` is used with its lower bound 65536. Otherwise, the test fails.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1336830220