On Mon, 30 Oct 2023 10:29:56 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 80:
> 
>> 78:   FILE* f = os::fopen("/proc/self/maps", "r");
>> 79:   if (f != nullptr) {
>> 80:     static constexpr size_t linesize = sizeof(ProcMapsInfo);
> 
> Make this `constexpr const`, remove `static`.

Lets go with constexpr; should imply const.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1378423904

Reply via email to