On Wed, 1 Nov 2023 09:48:39 GMT, Johan Sjölen <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 99:
>
>> 97: }
>> 98:
>> 99: bool add(const void* from, const void* to, MEMFLAGS f) {
>
> Please mention that we're `add`ing in sorted order, that is that `forall R
> \in _ranges: R.to <= from` holds.
I wasn't sure about that. Do we always? Are NMT regions guaranteed to be
sorted? (Dimly remember cases where that weren't so)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1378593459
