On Wed, 8 Nov 2023 15:59:16 GMT, Serguei Spitsyn <[email protected]> wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1978:
>>
>>> 1976: }
>>> 1977: if (target_jt == nullptr) { // unmounted virtual thread
>>> 1978: hs_cl->do_vthread(target_h); // execute handshake closure
>>> callback on current thread directly
>>
>> I think comment should be: s/current thread/unmounted vthread
>
> Thank you for the comment but I'm not sure what do you mean.
> If target virtual thread is unmounted we execute the hs_cl callback on
> current thread.
Ok, I see. When I read "closure executed on" I think of the intended target
thread of the closure rather than the current thread used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16460#discussion_r1395894618
