On Tue, 14 Nov 2023 21:33:37 GMT, Jonathan Joo <j...@openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update parallel workers time after Remark

Thanks for addressing my comments. I have a few more things:

- I think all changes to `test_g1ServiceThread.cpp` can be reverted. Should not 
be needed now
- Please fix all whitespace issues
- Should we move the VMThread and StringDedup counters into `CPUTimeCounters` 
as well? Any problem with this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15082#issuecomment-1812105608

Reply via email to