On Wed, 22 Nov 2023 16:24:24 GMT, suchismith1993 <d...@openjdk.org> wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.a shared archive
>> file on AIX.
>> Hence we are providing a function which will additionally search for .a file
>> on AIX ,when the search for .so file fails.
>
> suchismith1993 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> change macro position
some nits you might want to consider.
src/hotspot/os/aix/os_aix.cpp line 3064:
> 3062:
> 3063: //Replaces provided path with alternate path for the given file,if it
> doesnt exist.
> 3064: //For AIX,this replaces .so with .a.
Suggestion:
// Replaces the specified path with an alternative path for the given file if
the original path doesn't exist.
// For AIX, this replaces extension from ".so" to ".a".
src/hotspot/os/aix/os_aix.cpp line 3065:
> 3063: //Replaces provided path with alternate path for the given file,if it
> doesnt exist.
> 3064: //For AIX,this replaces .so with .a.
> 3065: void os::Aix::mapAlternateName(char* buffer, const char *extension) {
Suggestion:
void os::Aix::map_alternate_name(char* buffer, const char *extension) {
src/hotspot/os/aix/os_aix.hpp line 181:
> 179: static int stat64x_via_LIBPATH(const char* path, struct stat64x* stat);
> 180: // Provide alternate path name,if file does not exist.
> 181: static void mapAlternateName(char* buffer, const char *extension);
Suggestion:
// Provides alternate path name, if file does not exist.
static void map_alternate_name(char* buffer, const char *extension);
-------------
Changes requested by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/16604#pullrequestreview-1745734586
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1402935976
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1402936171
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1402936497
