On Thu, 21 Dec 2023 09:57:08 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> There will be only few libraries in the list. With this assumption Thomas >> suggested to use just a simple array. > > Let's keep it simple. A linear array of only a few items is easily scanned, > probably faster than pointer hopping hash table entries. Not that it matters > in any way for the few calls to dlopen. > > Also, avoiding hotspot structures preserves layer integrity (porting_aix does > not pull anything from hotspot so far) and prevents initialisation time > dependencies. Not sure whether ConcurrentHashTable works before VM init, but > with Joachimes current solution, we can call dlopen at any time in VM life. I don't like introducing unnecessary limitations. Are we sure nobody will ever need more than 1024 handles? Can't we at least use a GrowableArray or something like that? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433865222
