On Wed, 17 Jan 2024 17:35:39 GMT, Tom Rodriguez <[email protected]> wrote:
>> The changes for JDK-8287061 didn't update the SA decoding logic and there
>> are other places where the decoding has gotten out of sync with HotSpot.
>> Some of them can't be tested because they are part of JVMCI but I've added a
>> directed test for the JDK-8287061 code and a more brute force test that
>> tries to decode everything.
>
> Tom Rodriguez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove testdebuginfodecode command
test/hotspot/jtreg/ProblemList-generational-zgc.txt line 108:
> 106: serviceability/sa/sadebugd/ClhsdbAttachToDebugServer.java 8307393
> generic-all
> 107: serviceability/sa/sadebugd/ClhsdbTestConnectArgument.java 8307393
> generic-all
> 108: serviceability/sa/ClhsdbTestAllocationMerge.java 8307393
> generic-all
Do you need to add TestDebugInfoDecode.java?
test/hotspot/jtreg/serviceability/sa/TestDebugInfoDecode.java line 109:
> 107: if (args == null || args.length == 0) {
> 108: try {
> 109: theApp = new LingeredApp();
Is there a reason why previously you had used LingeredAppWithEnum and now you
are using LingeredApp?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1456382492
PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1456375716
