On Wed, 17 Jan 2024 19:34:29 GMT, Chris Plummer <[email protected]> wrote:
>> Tom Rodriguez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove testdebuginfodecode command
>
> test/hotspot/jtreg/serviceability/sa/TestDebugInfoDecode.java line 109:
>
>> 107: if (args == null || args.length == 0) {
>> 108: try {
>> 109: theApp = new LingeredApp();
>
> Is there a reason why previously you had used LingeredAppWithEnum and now you
> are using LingeredApp?
Both were chosen as a result of copy/paste from existing tests and it honestly
doesn't matter. The Xcomp is what's producing nmethods so the actual test
doesn't matter.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1456392560