> Test uses  jdk.test.lib.Utils.getFreePort() when launching a new Java command.
> Looks like it already recognises "java.rmi.server.ExportException: Port 
> already in use: " and retries, but there is a long-standing typo in the check.
> 
> e.g. 
> 
> test output:
> Error: Exception thrown by the agent: java.rmi.server.ExportException: Port 
> already in use: 37049; nested exception is: 
>       java.net.BindException: Address already in use
>       
> Test checks for:
>         !output.getOutput().contains("Exception thrown by the agent : 
> java.rmi.server.ExportException: Port already in use")
>               
> Oops, we have an extra space in there.  A day-one typo from JDK-7195249.
> 
> While here, try to clarify the while loop which recognises this port failure. 
>  Also add something to clarify which test(s) failed, and correct a comment in 
> test2 of AbstractFilePermissionTest.java

Kevin Walls has updated the pull request incrementally with one additional 
commit since the last revision:

  show exit code

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18470/files
  - new: https://git.openjdk.org/jdk/pull/18470/files/78456dac..5047f7d4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18470&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18470&range=00-01

  Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18470.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18470/head:pull/18470

PR: https://git.openjdk.org/jdk/pull/18470

Reply via email to