On Mon, 25 Mar 2024 22:46:47 GMT, Kevin Walls <kev...@openjdk.org> wrote:

>> Test uses  jdk.test.lib.Utils.getFreePort() when launching a new Java 
>> command.
>> Looks like it already recognises "java.rmi.server.ExportException: Port 
>> already in use: " and retries, but there is a long-standing typo in the 
>> check.
>> 
>> e.g. 
>> 
>> test output:
>> Error: Exception thrown by the agent: java.rmi.server.ExportException: Port 
>> already in use: 37049; nested exception is: 
>>      java.net.BindException: Address already in use
>>      
>> Test checks for:
>>         !output.getOutput().contains("Exception thrown by the agent : 
>> java.rmi.server.ExportException: Port already in use")
>>              
>> Oops, we have an extra space in there.  A day-one typo from JDK-7195249.
>> 
>> While here, try to clarify the while loop which recognises this port 
>> failure.  Also add something to clarify which test(s) failed, and correct a 
>> comment in test2 of AbstractFilePermissionTest.java
>
> Kevin Walls has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   show exit code

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18470#pullrequestreview-1958989271

Reply via email to