On Tue, 26 Mar 2024 18:18:39 GMT, Bill Huang <bhu...@openjdk.org> wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumulation of unnecessary files in the default temporary directory, which
>> can affect the system's storage and potentially influence subsequent test
>> runs.
>>
>> Our review identified that several tests create temporary files or socket
>> files without ensuring their removal post-execution.
>> - Direct calls to java.io.File.createTempFile and
>> java.nio.file.Files.createTempFile without adequate cleanup.
>> - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not
>> explicitly removing socket files post-use.
>
> Bill Huang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/java/nio/channels/unixdomain/Bind.java
>
> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
test/jdk/java/nio/channels/unixdomain/NonBlockingAccept.java line 68:
> 66: // or exception could be thrown otherwise
> 67: } finally {
> 68: Files.deleteIfExists(addr.getPath());
Hello Bill, `addr` can be `null` here, so this has a potential of a
`NullPointerException`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1548038473
