On Sat, 25 May 2024 06:21:51 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> This is a simple noreg cleanup. The motivation was that I noticed javac
>> doesn't recognise package.html files well.
>>
>> Some of the contents of the `package.html` files (and code in the package)
>> may be outdated, but I think it is out of scope for this PR.
>>
>> I have also changed three `{@link }` usages with the `href` that would have
>> been in the generated HTML.
>> Because referencing an element from an other module wouldn't work even when
>> using the `module/package.class#member`, if the `module-info.java` file does
>> not have "require `<name>`".
>>
>> I am referring to line 69 in
>> `src/java.management/share/classes/javax/management/monitor/package-info.java`
>> and lines 90 and 120 in
>> `src/java.management/share/classes/javax/management/remote/package-info.java`
>>
>> Adding 2 dependencies just for 3 links didn't seem right.
>>
>> edit: tier 1 passes on my machine, will check why a certain test fails
>> later. As this change shouldn't cause breakage
>>
>>
>> ==============================
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>>
>> jtreg:test/hotspot/jtreg:tier1_serviceability 353 353 0 0
>>
>> ==============================
>> TEST SUCCESS
>
> src/java.management/share/classes/java/lang/management/package-info.java line
> 27:
>
>> 25:
>> 26: /**
>> 27: * Provides the management interfaces for monitoring and management of
>> the
>
> I assume you used a script to convert these, I'm just curious why puts two
> spaces after the *, the usual convention is one. It's not a big deal but if
> this is something that can be fixed in the scripts then it would avoid a
> future cleanup.
I think it can be fixed, I just thought one space looked cramped
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19399#discussion_r1614530454
