On Fri, 24 May 2024 18:11:18 GMT, Nizar Benalla <[email protected]> wrote:
> This is a simple noreg cleanup. The motivation was that I noticed javac
> doesn't recognise package.html files well.
>
> Some of the contents of the `package.html` files (and code in the package)
> may be outdated, but I think it is out of scope for this PR.
>
> I have also changed three `{@link }` usages with the `href` that would have
> been in the generated HTML.
> Because referencing an element from an other module wouldn't work even when
> using the `module/package.class#member`, if the `module-info.java` file does
> not have "require `<name>`".
>
> I am referring to line 69 in
> `src/java.management/share/classes/javax/management/monitor/package-info.java`
> and lines 90 and 120 in
> `src/java.management/share/classes/javax/management/remote/package-info.java`
>
> Adding 2 dependencies just for 3 links didn't seem right.
>
> edit: passes all tests, the failing test is a github actions issue
I don't think that is a goal.
As for why I didn't use Markdown here, it would have made potentially
backporting these changes more difficult.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19399#issuecomment-2132376943
