On Thu, 30 May 2024 00:17:04 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 1. java_lang_VirtualThread::is_instance(thread_oop) ->
>> thread_oop->is_a(vmClasses::BaseVirtualThread_klass()); 2. calculating
>> nWant(mon->contentions())
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1524:
>
>> 1522: nWant_Skip++;
>> 1523: }
>> 1524: }
>
> Thank you for taking care about this issue.
> The nWant_Skip and and the fragment with lines 1518-1524 would not be needed
> if the function `Threads::get_pending_threads()` is fixed instead:
>
> - if (java_lang_VirtualThread::is_instance(thread_oop)) {
> + if (thread_oop->is_a(vmClasses::BaseVirtualThread_klass())) {
> ``
Thank you for your correction. The code has been updated accordingly your
suggest. I need redo the additional testing to verify it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19405#discussion_r1619669502
