On Tue, 4 Jun 2024 05:27:48 GMT, David Holmes <[email protected]> wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Print mounted virtual thread after carrier
>
> src/hotspot/share/runtime/javaThread.cpp line 1832:
>
>> 1830: st->print("\t");
>> 1831: indentation--;
>> 1832: }
>
> Suggestion:
>
> while (indentation-- > 0) {
> st->print("\t");
> }
>
> Though not sure using `\t` is the best way to indent this as stream
> indentation is based on spaces.
Actually I'm not sure what this indentation actually does at this location and
its affect on other user's of this API. I would have expected the caller to set
up the necessary indentation in the stream that gets passed in. I see you inc
the indentation but then use the current indentation to insert multiple tabs -
which should not be necessary if the stream indentation works correctly. ???
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1625368549
