On Wed, 4 Sep 2024 11:02:55 GMT, Kevin Walls <[email protected]> wrote:
>> Deprecation annotations and warnings on starting the tool(s).
>> Handle man page in a separate issue.
>
> Kevin Walls has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - --connect message
> - Test updates for --connect
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java line 73:
> 71: System.out.println(" --connect
> [<serverid>@]<host>[:registryport][/servername] To connect to a remote debug
> server (debugd).");
> 72: System.out.println();
> 73: System.err.println("WARNING: --connect is deprecated and will
> be removed in a future release.");
This is `jhsdb $TOOL --help` output. Shouldn't this just have "(deprecated)"
before "To connect ..." rather than a blank line and warning? I assume the
changes should only print "WARNING" if the user attempts to run `jhsdb $TOOL
-connect ..`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1743565215
