On Thu, 5 Sep 2024 08:12:55 GMT, Kevin Walls <[email protected]> wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java line 75:
>>
>>> 73: System.out.println();
>>> 74: if (canConnectToRemote) {
>>> 75: System.out.println(" The --connect option is deprecated
>>> and will be removed in a future release.");
>>
>> It is ok to add this, but now there is no longer any help message to explain
>> what `--connect` does.
>
> We have line 71 saying "--connect .....To connect to a remote debug server
> (debugd)."
> It's a long line and scanning it people might not read it all, but too late
> to worry overly about that. 8-)
Ok. I was looking at the deletion of line 79. I didn't realize it was removed
because it pretty much just repeated line 71.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20830#discussion_r1745971013
