On Fri, 6 Jun 2025 11:34:04 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> There are a couple of jtreg tests, especially in the HS area, with very >> special assumptions about memory layout/sizes . >> Those fail when the address sanitizer is configured ( --enable-asan ). >> The change adds a way to tag those tests with 'requires' so that they can be >> avoided easily when running jtreg tests with ASAN enabled. >> Adjusting the tests for "pleasing" the sanitizer is not always desired (if >> possible for some tests it can be done later) . >> While at it, also same is also added for ubsan . > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > exclude AbsPathInImage test from asan Changes look good technically. No add'l requirements from my side. As already discussed, some reasoning why a particular test does not work with asan is more than desirable - it's required. As @plummercj said, @comments are ok if the reason can be condensed into a one-liner. I'll approve once the requests from others are honored. ------------- Changes requested by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25575#pullrequestreview-2907694852
