On Tue, 10 Jun 2025 06:42:46 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

>> There are a couple of jtreg tests, especially in the HS area, with very 
>> special assumptions about memory layout/sizes .
>> Those fail when the address sanitizer is configured ( --enable-asan ).
>> The change adds a way to tag those tests with 'requires' so that they can be 
>> avoided easily when running jtreg tests with ASAN enabled.
>> Adjusting the tests for "pleasing" the sanitizer is not always desired (if 
>> possible for some tests it can be done later) .
>> While at it, also same is also added for ubsan .
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add comments to tests

test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java line 52:

> 50:  * @library /test/lib
> 51:  * @requires vm.gc.Z & (os.family == "linux" | os.family == "windows" | 
> os.family == "mac")
> 52:  * @requires !vm.asan

You should duplicate the comment here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25575#discussion_r2138641241

Reply via email to