On Thu, 10 Jul 2025 00:08:26 GMT, Alex Menkov <amen...@openjdk.org> wrote:

> The fix adds guards against JVMTI_ERROR_WRONG_PHASE error in VMObjectAlloc 
> event handler.
> 
> Testing: fixed test on all platforms

Changes requested by sspitsyn (Reviewer).

Looks good.

test/hotspot/jtreg/serviceability/jvmti/VMEvent/libVMEventTest.c line 67:

> 65:   }
> 66: }
> 67: 

Nit: It'd be better to use the `RawMonitorLocker` defined in the 
`jvmti_common.hpp`.
The usages can be found in the 
`test/hotspot/jtreg/serviceability/jvmti/vthread` tests.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26231#pullrequestreview-3007845066
Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26231#pullrequestreview-3007849937
PR Review Comment: https://git.openjdk.org/jdk/pull/26231#discussion_r2199073603

Reply via email to