On Fri, 11 Jul 2025 00:18:07 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> The fix adds guards against JVMTI_ERROR_WRONG_PHASE error in VMObjectAlloc 
>> event handler.
>> 
>> Testing: fixed test on all platforms
>
> test/hotspot/jtreg/serviceability/jvmti/VMEvent/libVMEventTest.c line 67:
> 
>> 65:   }
>> 66: }
>> 67: 
> 
> Nit: It'd be better to use the `RawMonitorLocker` defined in the 
> `jvmti_common.hpp`.
> The usages can be found in the 
> `test/hotspot/jtreg/serviceability/jvmti/vthread` tests.

Sorry, my suggestion is no applicable. The problem is that this is not a c++ 
file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26231#discussion_r2199076469

Reply via email to