On Wed, 10 Sep 2025 07:23:58 GMT, Kim Barrett <[email protected]> wrote:
> > > Although the file "atomic.hpp" is being renamed to "atomicAccess.hpp", I > > > chose > > > to not rename the various "atomic_." and "atomic__." files. > > > > > > Could you motivate why you chose to not do that? > > I thought about it, and waffled back and forth. But I was trying to do as > much as possible of this change mechanically. Renaming a file involves > multiple steps that weren't all easily scriptable. (And I'd already messed up > a part of the renaming of atomic.hpp during patch development.) Also, this > change is going to be hard for backports as it is, and I think renamings > might make that worse. Renamings can also be annoying for archeology. But if > you think it's important... Sure, renames are annoying. I do think that it is bad to leave inconsistent names in a long-lived, evolving code base. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27135#issuecomment-3273979685
