On Thu, 25 Sep 2025 22:05:10 GMT, Dean Long <[email protected]> wrote:
>> I would rather keep this code as a debug only sanity check, but I would >> refactor it into a single function. Then the question remains what to do >> with the SA code, that still does nothing. > >> I would rather keep this code as a debug only sanity check, but I would >> refactor it into a single function. Then the question remains what to do >> with the SA code, that still does nothing. > > I think we can do even better and get rid of adjust_unextended_sp, moving the > debug check into get_deopt_original_pc. This moves the SA changes into > shared code, and fixes the anomaly that s390 never called > adjust_unextended_sp and thus never called the debug code to do the sanity > check. That is indeed even better. Nice. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27059#discussion_r2381117772
