On Wed, 24 Sep 2025 11:14:01 GMT, Manuel Hässig <[email protected]> wrote:
>> Dean Long has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - revert whitespace change >> - undo debug changes >> - cleanup > > src/hotspot/cpu/arm/frame_arm.cpp line 365: > >> 363: DEBUG_ONLY(verify_deopt_original_pc(sender_nm, _unextended_sp)); >> 364: } >> 365: } > > All of this could be `NOT_PRODUCT` and the method `const` if I did not miss > any side effects. Right, there is no adjustment anymore on any platform. I think this function and verify_deopt_original_pc only ever existed to support code that is now getting removed. So I could change the name to verify_unextended_sp() and make it const, but it might make more sense to remove both this function and verify_deopt_original_pc now. What do you think? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27059#discussion_r2377202692
