On Fri, 26 Sep 2025 01:22:50 GMT, Dean Long <[email protected]> wrote:
>> At one time, JSR292 support needed special logic to save and restore SP >> across method handle instrinsic calls, but that is no longer the case. The >> only platform that still does the save/restore is arm32, which is no longer >> necessary. The save/restore can be removed along with related APIs and >> logic. Note that the arm32 port is largely based on the x86 port, which >> stopped doing the save/restore in jdk9 >> ([JDK-8068945](https://bugs.openjdk.org/browse/JDK-8068945)). > > Dean Long has updated the pull request incrementally with one additional > commit since the last revision: > > copyright year update I have one last nit below. Otherwise, this looks good to me. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Frame.java line 85: > 83: > 84: protected void adjustForDeopt() { > 85: if ( pc != null) { Suggestion: if (pc != null) { ------------- Marked as reviewed by mhaessig (Committer). PR Review: https://git.openjdk.org/jdk/pull/27059#pullrequestreview-3270357612 PR Review Comment: https://git.openjdk.org/jdk/pull/27059#discussion_r2381017332
