On Fri, 23 Jan 2026 11:43:38 GMT, Kevin Walls <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactoring
>
> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 560:
>
>> 558: struct elf_symbol* sym = &(symtab->symbols[n]);
>> 559: if (sym->name != NULL &&
>> 560: offset >= sym->offset && offset <= sym->offset + sym->size) {
>
> Good to have this issue not affecting the symtab file.
> Is this change part of reverting the file, or is it needed?
It is required because `sym->size` is zero on my environment
(glibc-2.42-5.fc43.x86_64).
Maybe it should be handled as special case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29023#discussion_r2720885766
