On Fri, 23 Jan 2026 11:57:40 GMT, Kevin Walls <[email protected]> wrote:

>> It is required because `sym->size` is zero on my environment 
>> (glibc-2.42-5.fc43.x86_64).
>> Maybe it should be handled as special case.
>
> Right, we have been here before with recognising symbols when PC is off the 
> end of the defined symbol size in a different issue.  I think then we (you!) 
> tried hard not to simply recognise all symbols as being a byte larger than 
> they really are.  
> 
> sym->size for the specific symbol we care about here is zero?  Yes I'm seeing 
> 0 size for __restore_rt also.
> 
> Comparing offset == sym->offset as an alternative condition, without using 
> sym->size would work?

Good catch! But I feel conditions in `if` statement long a bit. So I added 
convenience function to check address range as `is_in()` and it works. How 
about this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29023#discussion_r2721192573

Reply via email to