On Fri, 13 Feb 2026 21:25:57 GMT, Alex Menkov <[email protected]> wrote:
>> On Linux Alpine, we get the following build error:
>>
>>
>> libproc_impl.h:99:4: error: 'off64_t' does not name a type; did you mean
>> 'off_t'?
>> 99 | off64_t vdso_offset; // offset of vDSO in core
>> | ^~~~~~~
>> | off_t
>>
>>
>> and
>>
>>
>> jdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:639:11: error:
>> implicit declaration of function 'sendfile64'; did you mean 'sendfile'?
>> [-Wimplicit-function-declaration]
>> 639 | if (sendfile64(lib_fd, ph->core->core_fd, &ofs, ph->core->vdso_size)
>> == -1) {
>> | ^~~~~~~~~~
>> | sendfile
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 639:
>
>> 637: lib_fd = fileno(tmpf);
>> 638: off_t ofs = ph->core->vdso_offset;
>> 639: if (sendfile(lib_fd, ph->core->core_fd, &ofs,
>> ph->core->vdso_size) == -1) {
>
> should it be `os::Linux::sendfile`?
Maybe.
But if we use 'os::Linux::sendfile', we should probably also do this
https://github.com/openjdk/jdk/blob/0196d4ecf69d9509d59a266e163308d0783eaa25/src/hotspot/share/services/heapDumper.cpp#L2156-L2165
and handle that sendfile might send less bytes than expected ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29710#discussion_r2811113631
