On Mon, 16 Feb 2026 08:02:03 GMT, Matthias Baesken <[email protected]> wrote:
>> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 639:
>>
>>> 637: lib_fd = fileno(tmpf);
>>> 638: off_t ofs = ph->core->vdso_offset;
>>> 639: if (sendfile(lib_fd, ph->core->core_fd, &ofs,
>>> ph->core->vdso_size) == -1) {
>>
>> should it be `os::Linux::sendfile`?
>
> Maybe.
> But if we use 'os::Linux::sendfile', we should probably also do this
> https://github.com/openjdk/jdk/blob/0196d4ecf69d9509d59a266e163308d0783eaa25/src/hotspot/share/services/heapDumper.cpp#L2156-L2165
>
> and handle that sendfile might send less bytes than expected ?
It is SA code, so we cannot use C++ classes in HotSpot.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29710#discussion_r2811319038
