On Fri, 20 Feb 2026 22:56:47 GMT, Alex Menkov <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: missed volatile keyword in the var definition
>
> src/hotspot/share/prims/jvmtiThreadState.inline.hpp line 170:
>
>> 168: JvmtiThreadState* state = current->jvmti_thread_state();
>> 169:
>> 170: if (state != nullptr && seen_interp_only_mode()) { // avoid
>> MutexLocker if possible
>
> Suggestion:
>
> if (state != nullptr && seen_interp_only_mode()) { // avoid holding
> JvmtiThreadState_lock if possible
Thanks for suggestion. In fact, this optimization is to avoid mutex operation,
it does not matter what exact lock is used. So, I wrote the comment this way
intentionally.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29800#discussion_r2835997315
