On Sat, 21 Feb 2026 09:06:25 GMT, Leonid Mesnik <[email protected]> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review: missed volatile keyword in the var definition
>
> src/hotspot/share/prims/jvmtiThreadState.hpp line 215:
> 
>> 213:   // It is cleared by EnterInterpOnlyModeClosure handshake.
>> 214:   bool is_pending_interp_only_mode() {
>> 215:     return AtomicAccess::load(&_pending_interp_only_mode);
> 
> Does it matter to made
> `Atomic<bool> _pending_interp_only_mode `
> ?
> 
> Seems the AtomicAccess is converted to `Atomic<T>` anywhere in the hotspot.

Yes, thanks. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29800#discussion_r2836056482

Reply via email to