On Wed, 11 Mar 2026 12:10:22 GMT, Coleen Phillimore <[email protected]> wrote:
>> In that case, "monitor matching" that the comment below is talking about >> would have failed. But this is all existing behavior that this PR does not >> change. > > So I left this block of code that's indented but I haven't figured out what > it means. I probably should have made this a draft PR until then but maybe > you can help. > > The comment in aload_0 makes no sense. No idea why it would return and not > be covered in an exception handler. Same with monitor_top. If the bytecode > can throw an exception it should fall through to the code below that creates > the exception edge. > In that case, "monitor matching" that the comment below is talking about > would have failed. But this is all existing behavior that this PR does not > change. Yes existing behaviour but I'm trying to point out that there may be more missing "exception edges". But I have to say I do not at all understand what this code is actually doing. Any bytecode can throw due to async exceptions under the right circumstances (these days only single-stepping or at a breakpoint?). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30171#discussion_r2922337018
