On Wed, 11 Mar 2026 02:11:27 GMT, Dean Long <[email protected]> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add some comments and fix the test.
>
> src/hotspot/share/runtime/interfaceSupport.cpp line 70:
> 
>> 68:   }
>> 69:   // Verify interpreter oopmap generation
>> 70:   if (!_no_async && GenerateOopMapALot) {
> 
> Based on the description of GenerateOopMapALot, I would expect this to 
> execute even for the no-async case.

But we don't - should I call it something different?
I don't really like the double negative tbh.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30171#discussion_r2917878391

Reply via email to