On Sat, 14 Mar 2026 03:14:34 GMT, Dean Long <[email protected]> wrote:
>> Anton Artemov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/master' into
>> JDK-8302745-unextended-sp-less-than-sp
>> - 8302745: Don't touch ARM code.
>> - 8302745: Addressed reviewer's comments.
>> - 8302745: Fix for sp > unextended_sp for x86 and aarch64.
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 352:
>
>> 350: void InterpreterMacroAssembler::prepare_to_jump_from_interpreted() {
>> 351: // set sender sp
>> 352: mov(r19_sender_sp, esp);
>
> Suggestion:
Could you please clarify this? Do you suggest to roll back to the old way and
set from the `sp` value or to remove this line completely?
> src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp line 1562:
>
>> 1560: // If member name is not null and is restored, it has to be
>> reflected, as if no
>> 1561: // MemberName was popped out of the stack when going through the
>> methods handle
>> 1562: __ decrement(rbcp, wordSize);
>
> I don't understand what this is doing. I would expect setting BCP to BCP-8
> to cause a crash.
`rbcp` happens to be `r13`, which is touched in methodHandles on this platform.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29744#discussion_r2941326023
PR Review Comment: https://git.openjdk.org/jdk/pull/29744#discussion_r2941332560
