On Mon, 16 Mar 2026 20:55:27 GMT, Dean Long <[email protected]> wrote:
>> Anton Artemov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into >> JDK-8302745-unextended-sp-less-than-sp >> - 8302745: Don't touch ARM code. >> - 8302745: Addressed reviewer's comments. >> - 8302745: Fix for sp > unextended_sp for x86 and aarch64. > > On x86, last_sp and sender_sp are essentially the same. Which means the > method handle linker adjustment can make last_sp point beyond SP, yet > safe_for_sender only cares about sender_sp/unextended_sp, not last_sp. The > more I look at this, the more I feel like the proposed change is not the way > to go. I do not agree with the comments in the JDK-8302320 PR discussion > that we should change unextended_sp rather than fix safe_for_sender. I am in > the opposite camp: fix only safe_for_sender. Thank you @dean-long for all the info you added to this PR. I don't have any strong opinion where to fix this issue, or even if it should be fixed. But I feel that we should somehow collect the info you added for the future. All the stack pointer variants like `expression`, `sender`, `unxtended`, `last` etc. are utterly confusing when starting to read the VM source. Adding that some platforms have padding needs doesn't make it easier. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29744#issuecomment-4073667256
