On Thu, 16 Apr 2026 05:44:21 GMT, David Holmes <[email protected]> wrote:
>> src/hotspot/share/utilities/accessFlags.hpp line 58:
>>
>>> 56: bool is_bridge () const { return (_flags &
>>> JVM_ACC_BRIDGE ) != 0; }
>>> 57: bool is_transient () const { return (_flags &
>>> JVM_ACC_TRANSIENT ) != 0; }
>>> 58: bool has_vararg () const { return (_flags &
>>> JVM_ACC_VARARGS ) != 0; }
>>
>> I recommend `is_varargs`, this flag is not enforced by the VM so technically
>> users can create class files that declare varargs methods without a trailing
>> array argument.
>
> +1
I renamed it to `is_varargs`. I originally picked `has_varargs` because that is
the name on the valhalla branch, but I am fine with this too.
>> src/hotspot/share/utilities/accessFlags.hpp line 64:
>>
>>> 62: bool is_interface () const { return (_flags &
>>> JVM_ACC_INTERFACE ) != 0; }
>>> 63: bool is_abstract () const { return (_flags &
>>> JVM_ACC_ABSTRACT ) != 0; }
>>> 64: bool is_strict_method() const { return (_flags &
>>> JVM_ACC_STRICT ) != 0; }
>>
>> If "strict method" sounds too weird, we can call this "strictfp" following
>> the original Java language modifier's name.
>
> This will be short-lived either way as valhalla gets rid of the legacy
> strictfp notion for methods anyway.
Renamed to `is_strictfp` instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30746#discussion_r3093147108
PR Review Comment: https://git.openjdk.org/jdk/pull/30746#discussion_r3093149786
