On Thu, 16 Apr 2026 12:01:32 GMT, Chen Liang <[email protected]> wrote:

>> Also do we need to handle ACC_MODULE, or do we not actually create an 
>> `instanceKlass` for those?
>
> On jdk side we never have Class for modules. These classfiles are exclusively 
> handled by Java code in ModuleDescriptor I think?

I have now changed it to use `compute_modifier_flags()` instead of 
`access_flags()` directly. With this, we get member-class modifiers printed. I 
expanded the test which shows that `private/protected static` gets printed. 
This matches the class' modifiers, which feels like the correct behavior. 

`ACC_MODULE` is not needed here because it never becomes an `InstanceKlass`. It 
is rejected as a normal class during parsing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30746#discussion_r3093244982

Reply via email to