On Fri, 17 Apr 2026 09:40:38 GMT, Thomas Schatzl <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use REALLOC_RETURN_TYPE in arena.hpp >> - Minor tweak of comment > > src/hotspot/share/opto/block.cpp line 1433: > >> 1431: uint size = 16; >> 1432: while( size <= from_idx ) size <<=1; >> 1433: _indices = REALLOC_RESOURCE_ARRAY( _indices, _max, size ); > > Suggestion: > > _indices = REALLOC_RESOURCE_ARRAY(_indices, _max, size ); I don't want to mess with the style in this file. There are other places where the code is written like this in this file. > src/hotspot/share/opto/compile.cpp line 1622: > >> 1620: _max_alias_types = grow_ats; >> 1621: _alias_types = REALLOC_ARENA_ARRAY(comp_arena(), _alias_types, >> old_ats, grow_ats); >> 1622: AliasType* ats = NEW_ARENA_ARRAY(comp_arena(), AliasType, >> new_ats); > > Pre-existing but this code aligns to the opening bracket, and similar code in > `loopnode.cpp` aligns on the "=". May be worth choosing one or other style. I'll update this if I get feedback from Compiler devs. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30786#discussion_r3099691515 PR Review Comment: https://git.openjdk.org/jdk/pull/30786#discussion_r3099699399
