On Fri, 17 Apr 2026 09:35:56 GMT, Thomas Schatzl <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Use REALLOC_RETURN_TYPE in arena.hpp
>> - Minor tweak of comment
>
> src/hotspot/share/interpreter/oopMapCache.cpp line 157:
>
>> 155: if (has_valid_mask() && mask_size() > small_mask_limit) {
>> 156: assert(_bit_mask[0] != 0, "should have pointer to C heap");
>> 157: FREE_C_HEAP_ARRAY((uintptr_t*)_bit_mask[0]);
>
> ?
I should have mentioned what this is. This part of the code puts a (uintptr_t*)
in the first element of _bit_mask if the bit mask is too large to fit the
static _bit_mask array. It is messing with the type system and we should
probably rewrite this to use a union instead.
> src/hotspot/share/memory/allocation.hpp line 513:
>
>> 511: resource_free_bytes(thread, (char*)(obj), (size) * sizeof(*obj))
>> 512:
>> 513: #define FREE_FAST(obj)\
>
> Is this used?
Seems not. Let's remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30786#discussion_r3099270011
PR Review Comment: https://git.openjdk.org/jdk/pull/30786#discussion_r3099273076
