On Wed, 29 Apr 2026 08:52:59 GMT, Casper Norrbin <[email protected]> wrote:
> Hi everyone, > > `TestLimitsUpdating.java` tests updating container limits live during a JVMs > runtime. One of these updates is to the number of CPUs available, from 2 to > 3. However, if there are only 2 CPUs visible to the JVM (total available, or > restricted by other means), this update is ignored, and we are bounded to 2 > CPUs. The tests expects the new limit to be 3, and thus fails. > > I propose we lower the number from 2/3 -> 1/2 to allow more configurations to > run this tests. If we only have 1 CPU available, we should instead skip the > test as we can't update the number of CPUs in a meaningful way. > > Testing: > - Local testing with both low and high number of CPUs available > - Oracle tiers 1-5 > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). The test changes seem reasonable, thank you. test/hotspot/jtreg/containers/docker/TestLimitsUpdating.java line 3: > 1: /* > 2: * Copyright (c) 2023, Red Hat, Inc. > 3: * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights > reserved. Please update the copyright. test/jdk/jdk/internal/platform/docker/TestLimitsUpdating.java line 3: > 1: /* > 2: * Copyright (c) 2023, Red Hat, Inc. > 3: * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights > reserved. Please update the copyright. ------------- Changes requested by phubner (Committer). PR Review: https://git.openjdk.org/jdk/pull/30985#pullrequestreview-4195479755 PR Review Comment: https://git.openjdk.org/jdk/pull/30985#discussion_r3159756440 PR Review Comment: https://git.openjdk.org/jdk/pull/30985#discussion_r3159757807
