On Wed, 29 Apr 2026 09:48:21 GMT, Casper Norrbin <[email protected]> wrote:

>> Hi everyone,
>> 
>> `TestLimitsUpdating.java` tests updating container limits live during a JVMs 
>> runtime. One of these updates is to the number of CPUs available, from 2 to 
>> 3. However, if there are only 2 CPUs visible to the JVM (total available, or 
>> restricted by other means), this update is ignored, and we are bounded to 2 
>> CPUs. The tests expects the new limit to be 3, and thus fails.
>> 
>> I propose we lower the number from 2/3 -> 1/2 to allow more configurations 
>> to run this tests. If we only have 1 CPU available, we should instead skip 
>> the test as we can't update the number of CPUs in a meaningful way.
>> 
>> Testing:
>> - Local testing with both low and high number of CPUs available
>> - Oracle tiers 1-5
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Casper Norrbin has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   updated copyright

LGTM. Thanks!

-------------

Marked as reviewed by phubner (Committer).

PR Review: https://git.openjdk.org/jdk/pull/30985#pullrequestreview-4198027419

Reply via email to