On Mon, 27 Apr 2026 23:51:41 GMT, Yasumasa Suenaga <[email protected]> wrote:

> We could see jtreg test failure in TestJhsdbJstackMixedWithXComp.java due to 
> unable unwinding from continuation stub.
> SA could unwind mixed call stacks since 
> [JDK-8377946](https://bugs.openjdk.org/browse/JDK-8377946), and enabled 
> TestJhsdbJstackMixedWithXComp tests in it. Hence the problem has been 
> suffered. The problem was reported in Valhalla, but it is potential to happen 
> on upstream, thus I proposed the fix to upstream.
> 
> There are 2 problems in LinuxAARCH64CFrame:
> 
> 1. On AArch64 which disables `PreserveFramePointer`, we cannot believe FP to 
> unwind call stacks, thus we might not be able to unwind call stacks from Java 
> frame (includes code blobs).
> 2. In continuation stub, we need to get SP/FP/PC from continuation entry.
> 
> So I fixed them in this PR, and it works on both upstream and Valhalla.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This file now has an odd mix of indentation, some 3 space and some 2 space. 
We're normally 4 spaces for .java files.  But don't change it all here and now 
as this is difficult enough already.

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/aarch64/LinuxAARCH64CFrame.java
 line 145:

> 143:         CodeBlob currentBlob = cc.findBlobUnsafe(pc());
> 144: 
> 145:         // This case is different from HotSpot. See JDK-8371194 for 
> details.

Maybe 
// See JDK-8371194 and JDK-8382548 for details.
Or just remove.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30959#issuecomment-4350987202
PR Review Comment: https://git.openjdk.org/jdk/pull/30959#discussion_r3166679448

Reply via email to