On Thu, 30 Apr 2026 09:13:46 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> We could see jtreg test failure in TestJhsdbJstackMixedWithXComp.java due to 
>> unable unwinding from continuation stub.
>> SA could unwind mixed call stacks since 
>> [JDK-8377946](https://bugs.openjdk.org/browse/JDK-8377946), and enabled 
>> TestJhsdbJstackMixedWithXComp tests in it. Hence the problem has been 
>> suffered. The problem was reported in Valhalla, but it is potential to 
>> happen on upstream, thus I proposed the fix to upstream.
>> 
>> There are 2 problems in LinuxAARCH64CFrame:
>> 
>> 1. On AArch64 which disables `PreserveFramePointer`, we cannot believe FP to 
>> unwind call stacks, thus we might not be able to unwind call stacks from 
>> Java frame (includes code blobs).
>> 2. In continuation stub, we need to get SP/FP/PC from continuation entry.
>> 
>> So I fixed them in this PR, and it works on both upstream and Valhalla.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Yasumasa Suenaga has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix comments

Thanks!

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30959#pullrequestreview-4204207893

Reply via email to